linux-kernel - Re: [PATCH] selftests: Add VRF icmp error route lookup test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <699475546.4794.1597173063863.JavaMail.zimbra@efficios.com>
Date:   Tue, 11 Aug 2020 15:11:03 -0400 (EDT)
From:   Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To:     David Ahern <dsahern@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Michael Jeanson <mjeanson@...icios.com>,
        David Ahern <dsahern@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] selftests: Add VRF icmp error route lookup test

----- On Aug 11, 2020, at 2:57 PM, David Ahern dsahern@...il.com wrote:

> On 8/11/20 11:28 AM, David Miller wrote:
>> From: Michael Jeanson <mjeanson@...icios.com>
>> Date: Thu,  6 Aug 2020 14:51:21 -0400
>> 
>>> The objective is to check that the incoming vrf routing table is selected
>>> to send an ICMP error back to the source when the ttl of a packet reaches 1
>>> while it is forwarded between different vrfs.
>>>
>>> The first test sends a ping with a ttl of 1 from h1 to h2 and parses the
>>> output of the command to check that a ttl expired error is received.
>>>
>>> [This may be flaky, I'm open to suggestions of a more robust approch.]
>>>
>>> The second test runs traceroute from h1 to h2 and parses the output to
>>> check for a hop on r1.
>>>
>>> Signed-off-by: Michael Jeanson <mjeanson@...icios.com>
>> 
>> This patch does not apply cleanly to the current net tree.
>> 
> 
> It is also out of context since the tests fail on current net and net-next.
> 
> The tests along with the patches that fix the problem should be sent
> together.

One thing I am missing before this series can be considered for upstreaming
is an Acked-by of the 2 fixes for ipv4 and ipv6 from you, as maintainer
of l3mdev, if you think the approach I am taking with those fixes makes sense.

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com