linux-kernel - Re: [PATCH v2 1/2] scsi: ufs: Cleanup completed request without interrupt notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4da0c324952861608bca14df77720e805be881e5.camel@gmail.com>
Date:   Wed, 12 Aug 2020 16:42:39 +0200
From:   Bean Huo <huobean@...il.com>
To:     Stanley Chu <stanley.chu@...iatek.com>, avri.altman@....com
Cc:     alim.akhtar@...sung.com, asutoshd@...eaurora.org,
        jejb@...ux.ibm.com, martin.petersen@...cle.com, beanhuo@...ron.com,
        bvanassche@....org, tomas.winkler@...el.com, cang@...eaurora.org,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] scsi: ufs: Cleanup completed request without
 interrupt notification

On Wed, 2020-08-12 at 20:47 +0800, Stanley Chu wrote:
> Hi Avri, Bean,
> 
> On Tue, 2020-08-11 at 16:18 +0200, Bean Huo wrote:
> > From: Stanley Chu <stanley.chu@...iatek.com>
> > 
> > If somehow no interrupt notification is raised for a completed
> > request
> > and its doorbell bit is cleared by host, UFS driver needs to
> > cleanup
> > its outstanding bit in ufshcd_abort(). Otherwise, system may behave
> > abnormally by below flow:
> > 
> > After ufshcd_abort() returns, this request will be requeued by SCSI
> > layer with its outstanding bit set. Any future completed request
> > will trigger ufshcd_transfer_req_compl() to handle all "completed
> > outstanding bits". In this time, the "abnormal outstanding bit"
> > will be detected and the "requeued request" will be chosen to
> > execute
> > request post-processing flow. This is wrong because this request is
> > still "alive".
> > 
> > Signed-off-by: Stanley Chu <stanley.chu@...iatek.com>
> > Reviewed-by: Can Guo <cang@...eaurora.org>
> > Signed-off-by: Bean Huo <beanhuo@...ron.com>
> 
> Thanks Bean's patch integration.
> 
> Like Avri's comment in https://patchwork.kernel.org/patch/11683381/
> I think you could add Acked-by tag from Avri.
> 

Hi Avri
do I need to re-send the patchset to add your Acked-by tag?
or you will sign your acked-by statement and append this patch?

Thanks,
Bean

> 
> 
> Hi Avri,
> 
> Please correct above description if required.
> Thanks for your review! : )
> 
> 
> Thanks,
> 
> Stanley Chu
>