linux-kernel - Re: [PATCH] softirq: add irq off checking for __raise_softirq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Aug 2020 09:33:31 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Jiafei Pan <Jiafei.Pan@....com>, peterz@...radead.org,
        mingo@...nel.org, rostedt@...dmis.org, romain.perier@...il.com,
        will@...nel.org
Cc:     linux-kernel@...r.kernel.org, linux-rt-users@...r.kernel.org,
        jiafei.pan@....com, leoyang.li@....com, vladimir.oltean@....com,
        Jiafei Pan <Jiafei.Pan@....com>
Subject: Re: [PATCH] softirq: add irq off checking for __raise_softirq_irqoff

Jiafei Pan <Jiafei.Pan@....com> writes:
> __raise_softirq_irqoff will update per-CPU mask of pending softirqs,

Please write __raise_softirq_irqoff() so it's clear that this is about a
function.

>  void __raise_softirq_irqoff(unsigned int nr)
>  {
> +	/* This function can only be called in irq disabled context,
> +	 * otherwise or_softirq_pending will be interrupted by hardware
> +	 * interrupt, so that there will be unexpected issue.
> +	 */
> +	WARN_ON_ONCE(!irqs_disabled());

Please use lockdep_assert_irqs_disabled() instead.

Thanks,

        tglx