linux-kernel - Re: [PATCH] media: ov5640: Correct Bit Div register in clock tree diagram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200813215117.GI840@valkosipuli.retiisi.org.uk>
Date:   Fri, 14 Aug 2020 00:51:18 +0300
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Jacopo Mondi <jacopo@...ndi.org>
Cc:     Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Steve Longerbeam <slongerbeam@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Maxime Ripard <maxime@...no.tech>,
        Hans Verkuil <hverkuil@...all.nl>
Subject: Re: [PATCH] media: ov5640: Correct Bit Div register in clock tree
 diagram

On Wed, Aug 05, 2020 at 02:51:13PM +0200, Jacopo Mondi wrote:
> Hi Paul,
> 
> On Mon, Aug 03, 2020 at 11:06:58AM +0200, Paul Kocialkowski wrote:
> > Although the code is correct and doing the right thing, the clock diagram
> > showed the wrong register for the bit divider, which had me doubting the
> > understanding of the tree. Fix this to avoid doubts in the future.
> 
> Thanks for spotting this! Correct indeed!
> 
> I'm not sure it's worth a fixes tag, but just in case:
> Fixes: aa2882481cada ("media: ov5640: Adjust the clock based on the expected rate")

Added that.

> 
> 
> Acked-by: Jacopo Mondi <jacopo@...ndi.org>

Thanks, Paul and Jacopo!

-- 
Sakari Ailus