linux-kernel - Re: [PATCH v5 9/9] Revert "PCI: brcmstb: Wait for Raspberry Pi's firmware when present"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200814101556.GB19387@e121166-lin.cambridge.arm.com>
Date:   Fri, 14 Aug 2020 11:15:56 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
Cc:     f.fainelli@...il.com, gregkh@...uxfoundation.org, robh@...nel.org,
        wahrenst@....net, p.zabel@...gutronix.de,
        andy.shevchenko@...il.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        bcm-kernel-feedback-list@...adcom.com, tim.gover@...pberrypi.org,
        linux-pci@...r.kernel.org, helgaas@...nel.org,
        mathias.nyman@...ux.intel.com
Subject: Re: [PATCH v5 9/9] Revert "PCI: brcmstb: Wait for Raspberry Pi's
 firmware when present"

On Mon, Jun 29, 2020 at 06:18:45PM +0200, Nicolas Saenz Julienne wrote:
> This reverts commit 44331189f9082c7e659697bbac1747db3def73e7.
> 
> Now that the VL805 init routine is run through a reset controller driver
> the device dependencies are being taken care of by the device core. No
> need to do it manually here.
> 
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  drivers/pci/controller/pcie-brcmstb.c | 17 -----------------
>  1 file changed, 17 deletions(-)

Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@....com>

> diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
> index 7730ea845ff2..752f5b331579 100644
> --- a/drivers/pci/controller/pcie-brcmstb.c
> +++ b/drivers/pci/controller/pcie-brcmstb.c
> @@ -28,8 +28,6 @@
>  #include <linux/string.h>
>  #include <linux/types.h>
>  
> -#include <soc/bcm2835/raspberrypi-firmware.h>
> -
>  #include "../pci.h"
>  
>  /* BRCM_PCIE_CAP_REGS - Offset for the mandatory capability config regs */
> @@ -931,26 +929,11 @@ static int brcm_pcie_probe(struct platform_device *pdev)
>  {
>  	struct device_node *np = pdev->dev.of_node, *msi_np;
>  	struct pci_host_bridge *bridge;
> -	struct device_node *fw_np;
>  	struct brcm_pcie *pcie;
>  	struct pci_bus *child;
>  	struct resource *res;
>  	int ret;
>  
> -	/*
> -	 * We have to wait for Raspberry Pi's firmware interface to be up as a
> -	 * PCI fixup, rpi_firmware_init_vl805(), depends on it. This driver's
> -	 * probe can race with the firmware interface's (see
> -	 * drivers/firmware/raspberrypi.c) and potentially break the PCI fixup.
> -	 */
> -	fw_np = of_find_compatible_node(NULL, NULL,
> -					"raspberrypi,bcm2835-firmware");
> -	if (fw_np && !rpi_firmware_get(fw_np)) {
> -		of_node_put(fw_np);
> -		return -EPROBE_DEFER;
> -	}
> -	of_node_put(fw_np);
> -
>  	bridge = devm_pci_alloc_host_bridge(&pdev->dev, sizeof(*pcie));
>  	if (!bridge)
>  		return -ENOMEM;
> -- 
> 2.27.0
>