linux-kernel - Re: [PATCH] kernel/sys.c: Convert to use the preferred fallthrough macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200814103431.jytlvc4wgxb2yx57@wittgenstein>
Date:   Fri, 14 Aug 2020 12:34:31 +0200
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     akpm@...ux-foundation.org, tglx@...utronix.de, vbabka@...e.cz,
        daniel.m.jordan@...cle.com, Nicolas.Viennot@...sigma.com,
        walken@...gle.com, mchristi@...hat.com, arnd@...db.de,
        viro@...iv.linux.org.uk, thomascedeno@...gle.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/sys.c: Convert to use the preferred fallthrough
 macro

On Fri, Aug 14, 2020 at 04:57:18AM -0400, Miaohe Lin wrote:
> Convert the uses of fallthrough comments to fallthrough macro.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---

This matches what we have documented in:

Documentation/process/deprecated.rst
Documentation/process/coding-style.rst

I'm going to reference that info in the commit message.

Applied, queueing for post rc1.
Acked-by: Christian Brauner <christian.brauner@...ntu.com>

>  kernel/sys.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sys.c b/kernel/sys.c
> index ca11af9d815d..ab6c409b1159 100644
> --- a/kernel/sys.c
> +++ b/kernel/sys.c
> @@ -1753,7 +1753,7 @@ void getrusage(struct task_struct *p, int who, struct rusage *r)
>  
>  		if (who == RUSAGE_CHILDREN)
>  			break;
> -		/* fall through */
> +		fallthrough;
>  
>  	case RUSAGE_SELF:
>  		thread_group_cputime_adjusted(p, &tgutime, &tgstime);
> -- 
> 2.19.1
>