linux-kernel - Re: [PATCH] signal: Convert to use the preferred fallthrough macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200814103515.tobuao5kd42lcryn@wittgenstein>
Date:   Fri, 14 Aug 2020 12:35:15 +0200
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     oleg@...hat.com, ebiederm@...ssion.com, viro@...iv.linux.org.uk,
        pavel@....cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] signal: Convert to use the preferred fallthrough macro

On Fri, Aug 14, 2020 at 04:39:32AM -0400, Miaohe Lin wrote:
> Convert the uses of fallthrough comments to fallthrough macro.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---

This matches what we have documented in:

Documentation/process/deprecated.rst
Documentation/process/coding-style.rst

I'm going to reference that info in the commit message.

Applied, queueing for post rc1.
Acked-by: Christian Brauner <christian.brauner@...ntu.com>

>  kernel/signal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 6f16f7c5d375..27505ca5be2d 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -851,7 +851,7 @@ static int check_kill_permission(int sig, struct kernel_siginfo *info,
>  			 */
>  			if (!sid || sid == task_session(current))
>  				break;
> -			/* fall through */
> +			fallthrough;
>  		default:
>  			return -EPERM;
>  		}
> -- 
> 2.19.1
>