linux-kernel - Re: [PATCH] net: qrtr: fix usage of idr in port assignment to socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200814.135526.430805159179452727.davem@davemloft.net>
Date:   Fri, 14 Aug 2020 13:55:26 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fazilyildiran@...il.com
Cc:     kuba@...nel.org, courtney.cavin@...ymobile.com,
        bjorn.andersson@...aro.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, dvyukov@...gle.com, elver@...gle.com,
        andreyknvl@...gle.com, glider@...gle.com, necip@...gle.com,
        syzbot+f31428628ef672716ea8@...kaller.appspotmail.com
Subject: Re: [PATCH] net: qrtr: fix usage of idr in port assignment to
 socket

From: Necip Fazil Yildiran <fazilyildiran@...il.com>
Date: Fri, 14 Aug 2020 10:10:00 +0000

> diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
> index b4c0db0b7d31..52d0707df776 100644
> --- a/net/qrtr/qrtr.c
> +++ b/net/qrtr/qrtr.c
> @@ -693,22 +693,24 @@ static void qrtr_port_remove(struct qrtr_sock *ipc)
>  static int qrtr_port_assign(struct qrtr_sock *ipc, int *port)
>  {
>  	int rc;
> +	u32 min_port;

Please use reverse christmas tree ordering for local variables.