linux-kernel - Re: [PATCH] net: qrtr: fix usage of idr in port assignment to socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACT4Y+aTaB5YVYjMXSnonLmocO1FWs06DaOwHCiuweGD93M0kA@mail.gmail.com>
Date:   Sun, 16 Aug 2020 17:36:00 +0200
From:   Dmitry Vyukov <dvyukov@...gle.com>
To:     David Miller <davem@...emloft.net>
Cc:     Necip F. Yıldıran <fazilyildiran@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        courtney.cavin@...ymobile.com,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Marco Elver <elver@...gle.com>,
        Andrey Konovalov <andreyknvl@...gle.com>,
        Alexander Potapenko <glider@...gle.com>,
        Necip Fazil Yildiran <necip@...gle.com>,
        syzbot+f31428628ef672716ea8@...kaller.appspotmail.com
Subject: Re: [PATCH] net: qrtr: fix usage of idr in port assignment to socket

On Fri, Aug 14, 2020 at 10:55 PM David Miller <davem@...emloft.net> wrote:
>
> From: Necip Fazil Yildiran <fazilyildiran@...il.com>
> Date: Fri, 14 Aug 2020 10:10:00 +0000
>
> > diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
> > index b4c0db0b7d31..52d0707df776 100644
> > --- a/net/qrtr/qrtr.c
> > +++ b/net/qrtr/qrtr.c
> > @@ -693,22 +693,24 @@ static void qrtr_port_remove(struct qrtr_sock *ipc)
> >  static int qrtr_port_assign(struct qrtr_sock *ipc, int *port)
> >  {
> >       int rc;
> > +     u32 min_port;
>
> Please use reverse christmas tree ordering for local variables.

If Dave's comment is fixed:

Reviewed-by: Dmitry Vyukov <dvyukov@...gle.com>

(add this tag to the v2 of this patch).

Just in case: "reverse christmas tree" is when variable declarations
are sorted by line length (longest first).