linux-kernel - Re: [PATCH net] drivers/net/wan/hdlc_x25: Added needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200814.204121.2301287009173291675.davem@davemloft.net>
Date:   Fri, 14 Aug 2020 20:41:21 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xie.he.0141@...il.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-x25@...r.kernel.org,
        willemdebruijn.kernel@...il.com, ms@....tdt.de,
        andrew.hendry@...il.com
Subject: Re: [PATCH net] drivers/net/wan/hdlc_x25: Added needed_headroom
 and a skb->len check

From: Xie He <xie.he.0141@...il.com>
Date: Thu, 13 Aug 2020 11:17:04 -0700

> 1. Added a skb->len check
> 
> This driver expects upper layers to include a pseudo header of 1 byte
> when passing down a skb for transmission. This driver will read this
> 1-byte header. This patch added a skb->len check before reading the
> header to make sure the header exists.
> 
> 2. Added needed_headroom and set hard_header_len to 0
> 
> When this driver transmits data,
>   first this driver will remove a pseudo header of 1 byte,
>   then the lapb module will prepend the LAPB header of 2 or 3 bytes.
> So the value of needed_headroom in this driver should be 3 - 1.
> 
> Because this driver has no header_ops, according to the logic of
> af_packet.c, the value of hard_header_len should be 0.
> 
> Reason of setting needed_headroom and hard_header_len at this place:
> 
> This driver is written using the API of the hdlc module, the hdlc
> module enables this driver (the protocol driver) to run on any hardware
> that has a driver (the hardware driver) written using the API of the
> hdlc module.
> 
> Two other hdlc protocol drivers - hdlc_ppp and hdlc_raw_eth, also set
> things like hard_header_len at this place. In hdlc_ppp, it sets
> hard_header_len after attach_hdlc_protocol and before setting dev->type.
> In hdlc_raw_eth, it sets hard_header_len by calling ether_setup after
> attach_hdlc_protocol and after memcpy the settings.
> 
> 3. Reset needed_headroom when detaching protocols (in hdlc.c)
> 
> When detaching a protocol from a hardware device, the hdlc module will
> reset various parameters of the device (including hard_header_len) to
> the default values. We add needed_headroom here so that needed_headroom
> will also be reset.
> 
> Cc: Willem de Bruijn <willemdebruijn.kernel@...il.com>
> Cc: Martin Schiller <ms@....tdt.de>
> Cc: Andrew Hendry <andrew.hendry@...il.com>
> Signed-off-by: Xie He <xie.he.0141@...il.com>

Applied, thanks.