linux-kernel - Re: [PATCH] ASoC: hdac_hdmi: support 'ELD' mixer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hh7t3qbag.wl-tiwai@suse.de>
Date:   Sun, 16 Aug 2020 09:50:47 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Brent Lu <brent.lu@...el.com>
Cc:     alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Amadeusz Sławiński 
        <amadeuszx.slawinski@...ux.intel.com>,
        Guennadi Liakhovetski <guennadi.liakhovetski@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: hdac_hdmi: support 'ELD' mixer

On Fri, 14 Aug 2020 10:34:36 +0200,
Brent Lu wrote:
> @@ -1784,6 +1913,16 @@ int hdac_hdmi_jack_init(struct snd_soc_dai *dai, int device,
>  		}
>  	}
>  
> +	/* add control for ELD Bytes */
> +	err = hdac_hdmi_create_eld_ctl(component, pcm);
> +	if (err < 0) {
> +		dev_err(&hdev->dev,
> +			"eld control add failed with err: %d for pcm: %d\n",
> +			err, device);
> +		kfree(pcm);

pcm is allocated vida devm_kzalloc(), hence you shoudn't free it
explicitly.


thanks,

Takashi