linux-kernel - RE: [PATCH] ASoC: hdac_hdmi: support 'ELD' mixer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB36421D93BA72DFCC14F899AD975C0@DM6PR11MB3642.namprd11.prod.outlook.com>
Date:   Tue, 18 Aug 2020 00:53:39 +0000
From:   "Lu, Brent" <brent.lu@...el.com>
To:     Takashi Iwai <tiwai@...e.de>
CC:     "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Amadeusz Sławiński 
        <amadeuszx.slawinski@...ux.intel.com>,
        Guennadi Liakhovetski <guennadi.liakhovetski@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ASoC: hdac_hdmi: support 'ELD' mixer

> > +	/* add control for ELD Bytes */
> > +	err = hdac_hdmi_create_eld_ctl(component, pcm);
> > +	if (err < 0) {
> > +		dev_err(&hdev->dev,
> > +			"eld control add failed with err: %d for pcm: %d\n",
> > +			err, device);
> > +		kfree(pcm);
> 
> pcm is allocated vida devm_kzalloc(), hence you shoudn't free it explicitly.
Will fix it in v2. Thanks.

Brent
> 
> 
> thanks,
> 
> Takashi