linux-kernel - Re: [PATCH] ata: ahci: use ata_link_info() instead of ata_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e64e363a-55e5-7a71-ced7-fd28fc32aaa8@kernel.dk>
Date:   Sun, 16 Aug 2020 20:09:06 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Xu Wang <vulab@...as.ac.cn>, linux-ide@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ata: ahci: use ata_link_info() instead of
 ata_link_printk()

On 8/16/20 6:18 PM, Xu Wang wrote:
> Using ata_link_info() instead of ata_link_printk().
> 
> Signed-off-by: Xu Wang <vulab@...as.ac.cn>
> ---
>  drivers/ata/ahci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 0c0a736eb861..9d72d907b4ee 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -807,7 +807,7 @@ static int ahci_avn_hardreset(struct ata_link *link, unsigned int *class,
>  				(sstatus & 0xf) != 1)
>  			break;
>  
> -		ata_link_printk(link, KERN_INFO, "avn bounce port%d\n",
> +		ata_link_info(link,  "avn bounce port%d\n",
>  				port);

Why not collapse that into one line as well when making that change, as
it now fits just fine?

Apart from that, looks fine to me.

-- 
Jens Axboe