linux-kernel - Re: [PATCH] memory: samsung: exynos5422-dmc: Additional locking for 'curr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200817115435.GA2346@kozik-lap>
Date:   Mon, 17 Aug 2020 13:54:35 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Lukasz Luba <lukasz.luba@....com>
Cc:     oss-self-reviewed-patches@...thost.cambridge.arm.com,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-pm@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        kgene@...nel.org, b.zolnierkie@...sung.com
Subject: Re: [PATCH] memory: samsung: exynos5422-dmc: Additional locking for
 'curr_rate'

On Tue, Aug 11, 2020 at 11:17:27AM +0100, Lukasz Luba wrote:
> The 'curr_rate' is protected by local 'dmc->lock' in various places, but
> not in a function exynos5_dmc_get_status(). The lock protects frequency
> (and voltage) change process and the corresponding value stored in
> 'curr_rate'. Add the locking mechanism to protect the 'curr_rate' reading
> also in the exynos5_dmc_get_status().
> 
> Suggested-by: Krzysztof Kozlowski <krzk@...nel.org>
> Signed-off-by: Lukasz Luba <lukasz.luba@....com>
> ---
>  drivers/memory/samsung/exynos5422-dmc.c | 3 +++

Thanks, applied.

Best regards,
Krzysztof