linux-kernel - Re: [PATCH] memory: samsung: exynos5422-dmc: Additional locking for 'curr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b1cbd097-b31d-b1f2-243b-f4ed3074a9ce@arm.com>
Date:   Mon, 17 Aug 2020 13:28:43 +0100
From:   Lukasz Luba <lukasz.luba@....com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     oss-self-reviewed-patches@...thost.cambridge.arm.com,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-pm@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        kgene@...nel.org, b.zolnierkie@...sung.com
Subject: Re: [PATCH] memory: samsung: exynos5422-dmc: Additional locking for
 'curr_rate'

Hi Krzysztof,

On 8/17/20 12:54 PM, Krzysztof Kozlowski wrote:
> On Tue, Aug 11, 2020 at 11:17:27AM +0100, Lukasz Luba wrote:
>> The 'curr_rate' is protected by local 'dmc->lock' in various places, but
>> not in a function exynos5_dmc_get_status(). The lock protects frequency
>> (and voltage) change process and the corresponding value stored in
>> 'curr_rate'. Add the locking mechanism to protect the 'curr_rate' reading
>> also in the exynos5_dmc_get_status().
>>
>> Suggested-by: Krzysztof Kozlowski <krzk@...nel.org>
>> Signed-off-by: Lukasz Luba <lukasz.luba@....com>
>> ---
>>   drivers/memory/samsung/exynos5422-dmc.c | 3 +++
> 
> Thanks, applied.
> 

Thank you for applying it.

Regards,
Lukasz