linux-kernel - Re: [PATCH] ARM: dts: imx6sx-sdb: Add headphone detection for sound card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB334219C2EDDB25D1493DEC7EE35F0@VI1PR0402MB3342.eurprd04.prod.outlook.com>
Date:   Mon, 17 Aug 2020 13:57:51 +0000
From:   "S.j. Wang" <shengjiu.wang@....com>
To:     Fabio Estevam <festevam@...il.com>
CC:     Rob Herring <robh+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: dts: imx6sx-sdb: Add headphone detection for sound
 card

> >  &iomuxc {
> >         imx6x-sdb {
> > +               pinctrl-names = "default";
> > +               pinctrl-0 = <&pinctrl_hog>;
> 
> Instead of adding a hog group, please add the headphone detect GPIO under
> the audmux group like you did in the imx6sl-evk patch.
> 

I didn't put headphone detect GPIO in audmux group in imx6sl-evk patch,
Still in hog group.

And I think headphone detect GPIO is not belong to audmux group, it should
Be in hog group.

Best regards
Wang shengjiu