linux-kernel - Re: [PATCH] ARM: dts: imx6sx-sdb: Add headphone detection for sound card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOMZO5A6w96XOes-FUfLuGbV=-o9FVh4UWN8vX1M=aWh=Gg3Qw@mail.gmail.com>
Date:   Mon, 17 Aug 2020 21:38:01 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     "S.j. Wang" <shengjiu.wang@....com>
Cc:     Rob Herring <robh+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: dts: imx6sx-sdb: Add headphone detection for sound card

On Mon, Aug 17, 2020 at 10:57 AM S.j. Wang <shengjiu.wang@....com> wrote:

> I didn't put headphone detect GPIO in audmux group in imx6sl-evk patch,
> Still in hog group.

Ok, sorry. You grouped it with MX6SL_PAD_AUD_MCLK__AUDIO_CLK_OUT,
which I also think should not be part of the hog group.

> And I think headphone detect GPIO is not belong to audmux group, it should
> Be in hog group.

The hog group is better suited when there is no driver that can be
associated with that particular pin.

For the headphone GPIO detect, I think it makes sense to group it with
the other audio-related pinctrl pins.