linux-kernel - Re: [PATCH 2/2] block: fix ioprio_get/set(IOPRIO_WHO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2741d70f-31a9-3f8f-d74d-ce3de4c1bd3d@kernel.dk>
Date:   Mon, 17 Aug 2020 07:12:26 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Davidlohr Bueso <dave@...olabs.net>, akpm@...ux-foundation.org
Cc:     oleg@...hat.com, linux-kernel@...r.kernel.org,
        Greg Thelen <gthelen@...gle.com>,
        Davidlohr Bueso <dbueso@...e.de>
Subject: Re: [PATCH 2/2] block: fix ioprio_get/set(IOPRIO_WHO_PGRP) vs
 setuid(2)

On 8/16/20 5:31 PM, Davidlohr Bueso wrote:
> do_each_pid_thread(PIDTYPE_PGID) can race with a concurrent
> change_pid(PIDTYPE_PGID) that can move the task from one hlist
> to another while iterating. Serialize ioprio_get/set to take
> the tasklist_lock in this case.

LGTM:

Reviewed-by: Jens Axboe <axboe@...nel.dk>

-- 
Jens Axboe