linux-kernel - Re: [PATCH 43/44] dt: document HiSilicon SPMI controller and mfd/regulator properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+AsbJxsyjVt_YC=9ToqQC_0XPLymLkKnmpc0uuS-1eSQ@mail.gmail.com>
Date:   Mon, 17 Aug 2020 08:13:47 -0600
From:   Rob Herring <robh@...nel.org>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     mauro.chehab@...wei.com,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Lee Jones <lee.jones@...aro.org>,
        Linuxarm <linuxarm@...wei.com>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        devicetree@...r.kernel.org, Stephen Boyd <sboyd@...nel.org>
Subject: Re: [PATCH 43/44] dt: document HiSilicon SPMI controller and
 mfd/regulator properties

On Sat, Aug 15, 2020 at 3:55 AM Mauro Carvalho Chehab
<mchehab+huawei@...nel.org> wrote:
>
> Hi Rob,
>
> Em Fri, 14 Aug 2020 14:17:08 -0600
> Rob Herring <robh@...nel.org> escreveu:
>
> > On Wed, 12 Aug 2020 17:56:53 +0200, Mauro Carvalho Chehab wrote:
> > > Add documentation for the properties needed by the HiSilicon
> > > 6421v600 driver, and by the SPMI controller used to access
> > > the chipset.
> > >
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> > > ---
> > >  .../mfd/hisilicon,hi6421-spmi-pmic.yaml       | 182 ++++++++++++++++++
> > >  .../spmi/hisilicon,hisi-spmi-controller.yaml  |  54 ++++++
> > >  2 files changed, 236 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml
> > >  create mode 100644 Documentation/devicetree/bindings/spmi/hisilicon,hisi-spmi-controller.yaml
> > >
> >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/hisilicon,hisi-spmi-controller.example.dt.yaml: example-0: spmi@...24000:reg:0: [0, 4294066176, 0, 4096] is too long
>
> I was unable to find any way to solve this one. What's the proper
> way to set the length of the root reg on some example?

The default is 1 address and size cell. Either adjust 'reg' for that
or you can define a bus node:

bus {
  #address-cells = <2>;
  #size-cells = <2>;

  spmi@123 {
    ...
  };
};

My preference is doing the former.

Rob