linux-kernel - Re: [PATCH v5 1/3] perf jevents: Add support for parsing perchip/percore events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1265e9f4-fcfd-bb21-bf27-4ce56a04bcb9@linux.ibm.com>
Date:   Tue, 18 Aug 2020 14:46:10 +0530
From:   kajoljain <kjain@...ux.ibm.com>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     acme@...nel.org, peterz@...radead.org, mingo@...hat.com,
        mark.rutland@....com, alexander.shishkin@...ux.intel.com,
        pc@...ibm.com, jolsa@...hat.com, namhyung@...nel.org,
        yao.jin@...ux.intel.com, linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org, irogers@...gle.com,
        maddy@...ux.ibm.com, ravi.bangoria@...ux.ibm.com,
        anju@...ux.vnet.ibm.com, kan.liang@...ux.intel.com,
        nasastry@...ibm.com
Subject: Re: [PATCH v5 1/3] perf jevents: Add support for parsing
 perchip/percore events



On 8/16/20 10:05 PM, Andi Kleen wrote:
>> @@ -321,7 +331,7 @@ static void print_events_table_prefix(FILE *fp, const char *tblname)
>>  static int print_events_table_entry(void *data, char *name, char *event,
>>  				    char *desc, char *long_desc,
>>  				    char *pmu, char *unit, char *perpkg,
>> -				    char *metric_expr,
>> +				    char *metric_expr, char *aggr_mode,
>>  				    char *metric_name, char *metric_group,
>>  				    char *deprecated, char *metric_constraint)
> 
> We should really define a struct now to pass the parameters,
> the callback prototype is getting ridiculous.
> 
> I know it's my fault originally, but sorry you probably have to do it
> because you are touching it last.

Hi Andi,
   I will look into it.

Thanks,
Kajol Jain
> 
> -Andi
>