linux-kernel - RE: [PATCH v2] ASoC: hdac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB3642F2053B86CD4FE10383E1975C0@DM6PR11MB3642.namprd11.prod.outlook.com>
Date:   Tue, 18 Aug 2020 14:49:50 +0000
From:   "Lu, Brent" <brent.lu@...el.com>
To:     Kai Vehmanen <kai.vehmanen@...ux.intel.com>
CC:     "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Amadeusz Sławiński 
        <amadeuszx.slawinski@...ux.intel.com>,
        Guennadi Liakhovetski <guennadi.liakhovetski@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] ASoC: hdac_hdmi: support 'ELD' mixer

> 
> This is a bit iffy part. If same PCM is connected to multiple receivers, you
> return ELD data for the first one and ignore the rest. OTOH, this is inline with
> comment in hdac_hdmi_get_port_from_cvt() in that this pcm-to-many
> routing is not really supported by the driver now. But jack status reporting is
> done a port basis, not per PCM/CVTs, so this is not fully aligned.
> 
> Hmm. Given the proposed patch is aligned with the user-space interface
> exposed by patch_hdmi.c, I'm ok to go with this. Can you add an explicit
> comment to explain what is happening above?
> 
> Br, Kai

Fix it in v3. Thank you for the review.


Regards,
Brent