linux-kernel - Re: [PATCH] mm/slub: make add_full() condition more explicit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200819123713.38a2509a2b7651f14db33e61@linux-foundation.org>
Date:   Wed, 19 Aug 2020 12:37:13 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     <wuyun.wu@...wei.com>
Cc:     Christoph Lameter <cl@...ux.com>,
        Pekka Enberg <penberg@...nel.org>,
        "David Rientjes" <rientjes@...gle.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>, <liu.xiang6@....com.cn>,
        "open list:SLAB ALLOCATOR" <linux-mm@...ck.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/slub: make add_full() condition more explicit

On Tue, 11 Aug 2020 10:02:36 +0800 <wuyun.wu@...wei.com> wrote:

> From: Abel Wu <wuyun.wu@...wei.com>
> 
> The commit below is incomplete, as it didn't handle the add_full() part.
> commit a4d3f8916c65 ("slub: remove useless kmem_cache_debug() before remove_full()")
> 
> This patch checks for SLAB_STORE_USER instead of kmem_cache_debug(),
> since that should be the only context in which we need the list_lock for
> add_full().
> 

Does this contradict what the comment tells us?

* This also ensures that the scanning of full
* slabs from diagnostic functions will not see
* any frozen slabs.