linux-kernel - Re: [PATCH] ALSA: usb-audio: Add prevent wakeup from s3 state trig by Lenovo ThinkCentre TI024Gen3 USB-audio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Aug 2020 03:35:41 +0800
From:   kernel test robot <lkp@...el.com>
To:     penghao <penghao@...ontech.com>, perex@...ex.cz, tiwai@...e.com
Cc:     kbuild-all@...ts.01.org, alexander@...y.me,
        dan.carpenter@...cle.com, crwulff@...il.com, penghao@...ontech.com,
        gustavoars@...nel.org, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Add prevent wakeup from s3 state trig
 by Lenovo ThinkCentre TI024Gen3 USB-audio

Hi penghao,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on sound/for-next]
[also build test ERROR on v5.9-rc1 next-20200819]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/penghao/ALSA-usb-audio-Add-prevent-wakeup-from-s3-state-trig-by-Lenovo-ThinkCentre-TI024Gen3-USB-audio/20200819-200006
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: x86_64-rhel (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   sound/usb/card.c: In function 'usb_audio_probe':
   sound/usb/card.c:666:28: error: stray '\357' in program
     666 |   device_set_wakeup_enable(＆dev->dev, 0);
         |                            ^
   sound/usb/card.c:666:29: error: stray '\274' in program
     666 |   device_set_wakeup_enable(＆dev->dev, 0);
         |                             ^
   sound/usb/card.c:666:30: error: stray '\206' in program
     666 |   device_set_wakeup_enable(＆dev->dev, 0);
         |                              ^
>> sound/usb/card.c:666:34: error: incompatible type for argument 1 of 'device_set_wakeup_enable'
     666 |   device_set_wakeup_enable(＆dev->dev, 0);
         |                               ~~~^~~~~
         |                                  |
         |                                  struct device
   In file included from include/linux/device.h:644,
                    from include/linux/usb/ch9.h:36,
                    from include/linux/usb.h:6,
                    from sound/usb/card.c:29:
   include/linux/pm_wakeup.h:108:52: note: expected 'struct device *' but argument is of type 'struct device'
     108 | extern int device_set_wakeup_enable(struct device *dev, bool enable);
         |                                     ~~~~~~~~~~~~~~~^~~

# https://github.com/0day-ci/linux/commit/b49bfa7145277ea86b0487f7fd4e51566477f092
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review penghao/ALSA-usb-audio-Add-prevent-wakeup-from-s3-state-trig-by-Lenovo-ThinkCentre-TI024Gen3-USB-audio/20200819-200006
git checkout b49bfa7145277ea86b0487f7fd4e51566477f092
vim +/device_set_wakeup_enable +666 sound/usb/card.c

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (45509 bytes)