linux-kernel - RE: [PATCHv2] PCI: designware-ep: Fix the Header Type check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <HE1PR0402MB3371820E90A64B8B83D2CBA9845D0@HE1PR0402MB3371.eurprd04.prod.outlook.com>
Date:   Wed, 19 Aug 2020 04:55:43 +0000
From:   "Z.q. Hou" <zhiqiang.hou@....com>
To:     Rob Herring <robh@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        PCI <linux-pci@...r.kernel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Andrew Murray <amurray@...goodpenguin.co.uk>,
        Jingoo Han <jingoohan1@...il.com>,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>
Subject: RE: [PATCHv2] PCI: designware-ep: Fix the Header Type check

Hi Rob,

Thanks a lot for your review!

Regards,
Zhiqiang

> -----Original Message-----
> From: Rob Herring <robh@...nel.org>
> Sent: 2020年8月18日 21:52
> To: Z.q. Hou <zhiqiang.hou@....com>
> Cc: linux-kernel@...r.kernel.org; PCI <linux-pci@...r.kernel.org>; Lorenzo
> Pieralisi <lorenzo.pieralisi@....com>; Bjorn Helgaas
> <bhelgaas@...gle.com>; Andrew Murray
> <amurray@...goodpenguin.co.uk>; Jingoo Han <jingoohan1@...il.com>;
> Gustavo Pimentel <gustavo.pimentel@...opsys.com>
> Subject: Re: [PATCHv2] PCI: designware-ep: Fix the Header Type check
> 
> On Tue, Aug 18, 2020 at 3:35 AM Zhiqiang Hou <Zhiqiang.Hou@....com>
> wrote:
> >
> > From: Hou Zhiqiang <Zhiqiang.Hou@....com>
> >
> > The current check will result in the multiple function device fails to
> > initialize. So fix the check by masking out the multiple function bit.
> >
> > Fixes: 0b24134f7888 ("PCI: dwc: Add validation that PCIe core is set
> > to correct mode")
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@....com>
> > ---
> > V2:
> >  - Add marco PCI_HEADER_TYPE_MASK and print the masked value.
> >
> >  drivers/pci/controller/dwc/pcie-designware-ep.c | 3 ++-
> >  include/uapi/linux/pci_regs.h                   | 1 +
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> Reviewed-by: Rob Herring <robh@...nel.org>