linux-kernel - Re: linux-next: Tree for Aug 19 (scsi/libsas/)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Aug 2020 23:30:36 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: linux-next: Tree for Aug 19 (scsi/libsas/)

On 8/18/20 10:57 PM, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20200818:
> 

Is this some kind of mis-merge?

In sas_discover.c:

	case SAS_SATA_DEV:
	case SAS_SATA_PM:
#ifdef CONFIG_SCSI_SAS_ATA
		error = sas_discover_sata(dev);
		break;
#else
		pr_notice("ATA device seen but CONFIG_SCSI_SAS_ATA=N so cannot attach\n");
		fallthrough;
#endif
		fallthrough;	/* only for the #else condition above */




  CC [M]  drivers/scsi/libsas/sas_discover.o
In file included from ./../include/linux/compiler_types.h:65:0,
                 from <command-line>:0:
../drivers/scsi/libsas/sas_discover.c: In function 'sas_discover_domain':
../include/linux/compiler_attributes.h:214:41: warning: attribute 'fallthrough' not preceding a case label or default label
 # define fallthrough                    __attribute__((__fallthrough__))
                                         ^
../drivers/scsi/libsas/sas_discover.c:469:3: note: in expansion of macro 'fallthrough'
   fallthrough;
   ^~~~~~~~~~~
  CC      drivers/ide/ide-eh.o
../include/linux/compiler_attributes.h:214:41: error: invalid use of attribute 'fallthrough'
 # define fallthrough                    __attribute__((__fallthrough__))
                                         ^
../drivers/scsi/libsas/sas_discover.c:471:3: note: in expansion of macro 'fallthrough'
   fallthrough; /* only for the #else condition above */
   ^~~~~~~~~~~



-- 
~Randy
Reported-by: Randy Dunlap <rdunlap@...radead.org>