linux-kernel - Re: [PATCH v7 0/2] pwm: intel: Add PWM driver for a new SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8fba2174-9010-19f3-29bf-0a31219d3793@linux.intel.com>
Date:   Wed, 19 Aug 2020 16:46:54 +0800
From:   "Tanwar, Rahul" <rahul.tanwar@...ux.intel.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...el.com>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        linux-pwm@...r.kernel.org, Lee Jones <lee.jones@...aro.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>, songjun.Wu@...el.com,
        cheol.yong.kim@...el.com, qi-ming.wu@...el.com,
        rahul.tanwar.linux@...il.com, rtanwar@...linear.com
Subject: Re: [PATCH v7 0/2] pwm: intel: Add PWM driver for a new SoC


Hi Andy,

On 19/8/2020 3:54 pm, Andy Shevchenko wrote:
> On Wed, Aug 19, 2020 at 7:18 AM Tanwar, Rahul
> <rahul.tanwar@...ux.intel.com> wrote:
>>
>> Hi Andy,
>>
>> On 18/8/2020 4:38 pm, Andy Shevchenko wrote:
>>> On Tue, Aug 18, 2020 at 01:48:59PM +0800, Rahul Tanwar wrote:
>>>> Patch 1 adds dt binding document in YAML format.
>>>> Patch 2 add PWM fan controller driver for LGM SoC.
>>>>
>>>> v7:
>>>> - Address code quality related review concerns.
>>>> - Rename fan related property to pwm-*.
>>>> - Fix one make dt_binding_check reported error.
>>> I guess it misses the answer why pwm-fan can't be integrated into the soup?
>>>
>> Can you please elaborate more? I could not understand your point clearly.
> It's not mine, it's Uwe's. There is an hwmon module called pwm-fan. As
> far as *I* understand this, it can be utilized to control fans via PWM
> APIs. And Uwe asked you if you considered that and why you don't
> integrated  (coupled) it here.

Thanks for clarification. I now understand what Rob, Uwe & you mean by
pwm-fan. I will check in detail about it if we can integrate it with
pwm-fan hwmon driver.

Regards,
Rahul