linux-kernel - Re: v5.9-rc1 commit reliably breaks pci nvme detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200820171214.GA15207@infradead.org>
Date:   Thu, 20 Aug 2020 18:12:14 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     "Ahmed S. Darwish" <a.darwish@...utronix.de>,
        Keith Busch <kbusch@...nel.org>,
        linux-nvme@...ts.infradead.org, Sagi Grimberg <sagi@...mberg.me>,
        Chaitanya Kulkarni <chaitanya.kulkarni@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: v5.9-rc1 commit reliably breaks pci nvme detection

On Thu, Aug 20, 2020 at 11:10:58AM -0600, Jens Axboe wrote:
> To be fair, I've only heard this one complaint about it, so hopefully it's
> not too widespread. I'm on an x86-64 laptop myself with nvme, and it works
> just fine :-)

The cause for this is the weird NVMe of by ones, where 0 in a field
means 1.  So for the overflow to happen you need a controller that
supports USHORT_MAX queue entries.  Which don't seem to be all that
common.