linux-kernel - RE: dt-bindings: display: xlnx: mixer: Inconsistent pixel format terminology in dt docs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200820233817.GA508@xilinx.com>
Date:   Thu, 20 Aug 2020 16:38:18 -0700
From:   hyun.kwon@...inx.com (Hyun Kwon)
To:     Kenneth Sloat <ksloat@...ignlinxhs.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Cc:     Michal Simek <michals@...inx.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "laurent.pinchart@...asonboard.com" 
        <laurent.pinchart@...asonboard.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mark.rutland@....com" <mark.rutland@....com>
Subject: RE: dt-bindings: display: xlnx: mixer: Inconsistent pixel format
 terminology in dt docs

Hi Kenneth,

> -----Original Message-----
> From: Kenneth Sloat <ksloat@...ignlinxhs.com>
> Sent: Thursday, August 20, 2020 2:18 PM
> To: Hyun Kwon <hyunk@...inx.com>; linux-arm-kernel@...ts.infradead.org
> Cc: Michal Simek <michals@...inx.com>; dri-devel@...ts.freedesktop.org; linux-
> kernel@...r.kernel.org; laurent.pinchart@...asonboard.com;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
> mark.rutland@....com
> Subject: dt-bindings: display: xlnx: mixer: Inconsistent pixel format terminology
> in dt docs
> 
> Hello,
> 
> The Xilinx Video mixer IP uses the DRM fourcc string as a device tree binding in
> order to describe the format for a specific DRM layer/plane. Currently, in the
> device tree doc in
> "Documentation/devicetree/bindings/dma/xilinx/xilinx_frmbuf.txt" there is a list
> called "VIDEO FORMATS" with a table containing "Mixer IP Format" and
> associated "Driver supported Format String" (fourcc). In general, this table is not
> helpful, because "Mixer IP Format" does not match the Xilinx IP datasheet
> terminology for formats but rather some other commonly used nomenclature.
> This is also inconsistent from other Xilinx dts binding docs which specify the
> actual correct IP name and at times list other format nomenclature where
> helpful (i.e. xilinx_frmbuf.txt)
> 
> My suggestion is to remove the current "Mixer IP Format" strings in the doc and
> replace them with the actual IP names in the datasheet (which also match those
> used in Xilinx's Vivado FPGA tool). Otherwise, the programmer must cross
> reference other dts documentation or the code in order to figure these out. I am
> happy to provide a patch for this but wanted to throw out the suggestion first.

I agree. The bindings should be in sync with datasheet and not rely on
software definitions. Since the driver is only in Xilinx vendor tree,
please send directly to git@...inx.com.

Thanks!

-hyun

> 
> Thanks
> 
> Sincerely,
> Ken Sloat