linux-kernel - Re: [PATCH] net: dsa: b53: check for timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200821.114850.193253709080317487.davem@davemloft.net>
Date:   Fri, 21 Aug 2020 11:48:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     trix@...hat.com
Cc:     f.fainelli@...il.com, andrew@...n.ch, vivien.didelot@...il.com,
        kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: b53: check for timeout

From: trix@...hat.com
Date: Fri, 21 Aug 2020 06:56:00 -0700

> From: Tom Rix <trix@...hat.com>
> 
> clang static analysis reports this problem
> 
> b53_common.c:1583:13: warning: The left expression of the compound
>   assignment is an uninitialized value. The computed value will
>   also be garbage
>         ent.port &= ~BIT(port);
>         ~~~~~~~~ ^
> 
> ent is set by a successful call to b53_arl_read().  Unsuccessful
> calls are caught by an switch statement handling specific returns.
> b32_arl_read() calls b53_arl_op_wait() which fails with the
> unhandled -ETIMEDOUT.
> 
> So add -ETIMEDOUT to the switch statement.  Because
> b53_arl_op_wait() already prints out a message, do not add another
> one.
> 
> Fixes: 1da6df85c6fb ("net: dsa: b53: Implement ARL add/del/dump operations")
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Applied and queued up for -stable, thanks.