linux-kernel - Re: [PATCH] net: dsa: b53: check for timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b249a607-8963-f6c4-3852-0160b72427fc@gmail.com>
Date:   Fri, 21 Aug 2020 07:43:20 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     trix@...hat.com, andrew@...n.ch, vivien.didelot@...il.com,
        davem@...emloft.net, kuba@...nel.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: b53: check for timeout



On 8/21/2020 6:56 AM, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> clang static analysis reports this problem
> 
> b53_common.c:1583:13: warning: The left expression of the compound
>    assignment is an uninitialized value. The computed value will
>    also be garbage
>          ent.port &= ~BIT(port);
>          ~~~~~~~~ ^
> 
> ent is set by a successful call to b53_arl_read().  Unsuccessful
> calls are caught by an switch statement handling specific returns.
> b32_arl_read() calls b53_arl_op_wait() which fails with the
> unhandled -ETIMEDOUT.
> 
> So add -ETIMEDOUT to the switch statement.  Because
> b53_arl_op_wait() already prints out a message, do not add another
> one.
> 
> Fixes: 1da6df85c6fb ("net: dsa: b53: Implement ARL add/del/dump operations")

For future submissions: no need for a newline between your tags here, 
the Fixes tag is just a regular tag in the commit message.

> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian