linux-kernel - Re: [PATCH] mips/oprofile: Fix fallthrough placement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200821074821.GD8336@alpha.franken.de>
Date:   Fri, 21 Aug 2020 09:48:21 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     zhe.he@...driver.com
Cc:     rric@...nel.org, oprofile-list@...ts.sf.net,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mips/oprofile: Fix fallthrough placement

On Thu, Aug 20, 2020 at 08:54:40PM +0800, zhe.he@...driver.com wrote:
> From: He Zhe <zhe.he@...driver.com>
> 
> We want neither
> "
> include/linux/compiler_attributes.h:201:41: warning: statement will never
> be executed [-Wswitch-unreachable]
>   201 | # define fallthrough __attribute__((__fallthrough__))
>       |                      ^~~~~~~~~~~~~
> "
> nor
> "
> include/linux/compiler_attributes.h:201:41: warning: attribute
> 'fallthrough' not preceding a case label or default label
>   201 | # define fallthrough __attribute__((__fallthrough__))
>       |                      ^~~~~~~~~~~~~
> "
> 
> It's not worth adding one more macro. Let's simply place the fallthrough
> in between the expansions.
> 
> Signed-off-by: He Zhe <zhe.he@...driver.com>

there is already another patch for the problem, which I've applied
to mips-fixes.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]