linux-kernel - Re: [PATCH 0/2][next] update gdb scripts for lockless printk ringbuffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d81e8b0d-fa7f-1da1-671f-0541b94ad349@siemens.com>
Date:   Fri, 21 Aug 2020 10:55:00 +0200
From:   Jan Kiszka <jan.kiszka@...mens.com>
To:     Petr Mladek <pmladek@...e.com>,
        John Ogness <john.ogness@...utronix.de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Baoquan He <bhe@...hat.com>, Dave Young <dyoung@...hat.com>,
        Vivek Goyal <vgoyal@...hat.com>,
        Jonathan Corbet <corbet@....net>,
        Kieran Bingham <kbingham@...nel.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2][next] update gdb scripts for lockless printk
 ringbuffer

On 21.08.20 10:08, Petr Mladek wrote:
> On Fri 2020-08-14 23:31:23, John Ogness wrote:
>> Hi,
>>
>> When we brought in the new lockless printk ringbuffer, we overlooked the gdb
>> scripts. Here are a set of patches to implement gdb support for the new
>> ringbuffer.
>>
>> John Ogness (2):
>>   scripts/gdb: add utils.read_ulong()
>>   scripts/gdb: update for lockless printk ringbuffer
> 
> I am not fluent in the gdb macros and python so I did not try any
> deep review. But both patches work for me:
> 
> Tested-by: Petr Mladek <pmladek@...e.com>
> 
> I am going to give it few more days before pushing just in case there is
> another feedback.
> 

Thanks, perfect!

> Best Regards,
> Petr
> 
> BTW: Are you aware of https://github.com/crash-python/crash-python project?
>      The ambition is to implement "crash" features and even more into
>      gdb using python extensions. It similar approach like
>      scripts/gdb/
> 
>      crash-python is being developed sporadically in waves. It is
>      mostly during a week that is dedicated for such projects
>      at SUSE. It would be great to get more contributors.
> 

The problem with all those out-of-tree kernel debugging projects is that
they are even further away from the changes in upstream they need to
adjust to over and over again. It's already hard for scripts/gdb to keep
up as only few people are aware of the dependencies, and it's always
easy to forget. But it's getting better and better here IMHO. And that
was my idea behind pushing things into upstream.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux