linux-kernel - Re: [RFC PATCH V3] iomap: add support to track dirty state of sub pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200821133657.GU17456@casper.infradead.org>
Date:   Fri, 21 Aug 2020 14:36:57 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     "yukuai (C)" <yukuai3@...wei.com>,
        Gao Xiang <hsiangkao@...hat.com>, darrick.wong@...cle.com,
        david@...morbit.com, linux-xfs@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        yi.zhang@...wei.com
Subject: Re: [RFC PATCH V3] iomap: add support to track dirty state of sub
 pages

On Fri, Aug 21, 2020 at 07:12:34AM +0100, Christoph Hellwig wrote:
> iomap sets PagePrivate if a iomap_page structure is allocated.  Right
> now that means for all pages on a file system with a block size smaller
> than the page size, although I hope we reduce that scope a little.

I was thinking about that.  Is there a problem where we initially allocate
the page with a contiguous extent larger than the page, then later need
to write the page to a pair of extents?

If we're doing an unshare operation, then we know our src and dest iomaps
and can allocate the iop then.  But if we readahead, we don't necessarily
know our eventual dest.  So the conditions for skipping allocating an
iop are tricky to be sure we'll never need it.