lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 22 Aug 2020 18:12:02 +0200
From:   Takashi Iwai <>
To:     Connor McAdams <>
Cc:     Jaroslav Kysela <>,,
Subject: Re: [PATCH 03/20] ALSA: hda/ca0132 - Add surround channel config control.

On Fri, 21 Aug 2020 20:52:20 +0200,
Connor McAdams wrote:
> +static int ca0132_alt_add_speaker_channel_cfg_enum(struct hda_codec *codec)
> +{
> +	struct snd_kcontrol_new knew =
> +		HDA_CODEC_MUTE_MONO("Output: Channels",

This isn't good as a control element name.  It's not only specific
about the purpose, also the use of a letter like ':' may confuse the
user-space tools.  Please choose a different name like "Surround
Channel Mode", "Surround Channel Config" or such one.



Powered by blists - more mailing lists