linux-kernel - Re: [PATCH 03/20] ALSA: hda/ca0132 - Add surround channel config control.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h5z9abqy5.wl-tiwai@suse.de>
Date:   Sat, 22 Aug 2020 18:12:02 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Connor McAdams <conmanx360@...il.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/20] ALSA: hda/ca0132 - Add surround channel config control.

On Fri, 21 Aug 2020 20:52:20 +0200,
Connor McAdams wrote:
> 
> +static int ca0132_alt_add_speaker_channel_cfg_enum(struct hda_codec *codec)
> +{
> +	struct snd_kcontrol_new knew =
> +		HDA_CODEC_MUTE_MONO("Output: Channels",
> +				    SPEAKER_CHANNEL_CFG_ENUM, 1, 0, HDA_OUTPUT);

This isn't good as a control element name.  It's not only specific
about the purpose, also the use of a letter like ':' may confuse the
user-space tools.  Please choose a different name like "Surround
Channel Mode", "Surround Channel Config" or such one.


thanks,

Takashi