linux-kernel - Re: [PATCH 05/20] ALSA: hda/ca0132 - Add bass redirection controls.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h4koubqoq.wl-tiwai@suse.de>
Date:   Sat, 22 Aug 2020 18:17:41 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Connor McAdams <conmanx360@...il.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/20] ALSA: hda/ca0132 - Add bass redirection controls.

On Fri, 21 Aug 2020 20:52:22 +0200,
Connor McAdams wrote:
> 
> +static int ca0132_alt_add_bass_redirection_crossover(struct hda_codec *codec)
> +{
> +	const char *namestr = "Output: Bass Redirection Playback Volume";
> +	struct snd_kcontrol_new knew =
> +		HDA_CODEC_VOLUME_MONO(namestr, BASS_REDIRECTION_XOVER, 1, 0,
> +				HDA_OUTPUT);

This is no ideal name string for a control element, too.
Better to omit "Output:" prefix at least.


thanks,

Takashi