linux-kernel - Re: [PATCH net-next] net: Remove unnecessary intermediate variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200822.140758.1768310758210192749.davem@davemloft.net>
Date:   Sat, 22 Aug 2020 14:07:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     joe@...ches.com
Cc:     Jianlin.Lv@....com, netdev@...r.kernel.org, kuba@...nel.org,
        Song.Zhu@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: Remove unnecessary intermediate variables

From: Joe Perches <joe@...ches.com>
Date: Sat, 22 Aug 2020 14:03:31 -0700

> The compiler didn't inline the code without it.

Then the compiler had a good reason for doing so, or it's a compiler
bug that should be reported.

I would reject any patch that added inline to a foo.c file, so unless
you want to make suggestions that will cause a contributor's patch to
be rejected, I'd suggest you not recommend inline usage in this way.

Thank you.