linux-kernel - Re: [PATCH net-next] net: Remove unnecessary intermediate variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <979bf21913a57f4f402fbd859891907a6ada6209.camel@perches.com>
Date:   Sat, 22 Aug 2020 14:20:30 -0700
From:   Joe Perches <joe@...ches.com>
To:     David Miller <davem@...emloft.net>
Cc:     Jianlin.Lv@....com, netdev@...r.kernel.org, kuba@...nel.org,
        Song.Zhu@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: Remove unnecessary intermediate variables

On Sat, 2020-08-22 at 14:07 -0700, David Miller wrote:
> From: Joe Perches <joe@...ches.com>
> Date: Sat, 22 Aug 2020 14:03:31 -0700
> 
> > The compiler didn't inline the code without it.
> 
> Then the compiler had a good reason for doing so,

The "good" word choice there is slightly dubious.
Compilers make bad decisions all the time.

> or it's a compiler bug that should be reported.

<shrug>

Or just behavioral changes between versions, or
even just random compiler decisions that causes
known unrepeatable compilation output.

That happens all the time.

If you want it just as static without the
inline/__always_inline marking, let me know.