linux-kernel - Re: [PATCH V2 5/7] PCI: qcom: Do PHY power on before PCIe init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200823154656.GU2639@vkoul-mobl>
Date:   Sun, 23 Aug 2020 21:16:56 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Sivaprakash Murugesan <sivaprak@...eaurora.org>
Cc:     agross@...nel.org, bjorn.andersson@...aro.org, bhelgaas@...gle.com,
        robh+dt@...nel.org, kishon@...com, svarbanov@...sol.com,
        lorenzo.pieralisi@....com, p.zabel@...gutronix.de,
        mgautam@...eaurora.org, smuthayy@...eaurora.org,
        varada@...eaurora.org, linux-arm-msm@...r.kernel.org,
        linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Selvam Sathappan Periakaruppan <speriaka@...eaurora.org>
Subject: Re: [PATCH V2 5/7] PCI: qcom: Do PHY power on before PCIe init

On 29-07-20, 21:00, Sivaprakash Murugesan wrote:
> Commit cc1e06f033af ("phy: qcom: qmp: Use power_on/off ops for PCIe")
> changed phy ops from init/deinit to power on/off, due to this phy enable
> is getting called after PCIe init.
> 
> On some platforms like ipq8074 phy should be inited before accessing the
> PCIe register space, otherwise the system would hang.

Have you verified that this causes no regression on sdm845 and other
platforms?

> So move phy_power_on API before PCIe init.
> 
> Fixes: commit cc1e06f033af ("phy: qcom: qmp: Use power_on/off ops for PCIe")

Is this a fix..? You are updating sequencing for a new platform

> Co-developed-by: Selvam Sathappan Periakaruppan <speriaka@...eaurora.org>
> Signed-off-by: Selvam Sathappan Periakaruppan <speriaka@...eaurora.org>
> Signed-off-by: Sivaprakash Murugesan <sivaprak@...eaurora.org>
> ---
>  drivers/pci/controller/dwc/pcie-qcom.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
> index 3aac77a..e1b5651 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom.c
> @@ -1265,18 +1265,18 @@ static int qcom_pcie_host_init(struct pcie_port *pp)
>  
>  	qcom_ep_reset_assert(pcie);
>  
> -	ret = pcie->ops->init(pcie);
> +	ret = phy_power_on(pcie->phy);
>  	if (ret)
>  		return ret;
>  
> -	ret = phy_power_on(pcie->phy);
> +	ret = pcie->ops->init(pcie);
>  	if (ret)
> -		goto err_deinit;
> +		goto err_disable_phy;
>  
>  	if (pcie->ops->post_init) {
>  		ret = pcie->ops->post_init(pcie);
>  		if (ret)
> -			goto err_disable_phy;
> +			goto err_deinit;
>  	}
>  
>  	dw_pcie_setup_rc(pp);
> @@ -1295,10 +1295,10 @@ static int qcom_pcie_host_init(struct pcie_port *pp)
>  	qcom_ep_reset_assert(pcie);
>  	if (pcie->ops->post_deinit)
>  		pcie->ops->post_deinit(pcie);
> -err_disable_phy:
> -	phy_power_off(pcie->phy);
>  err_deinit:
>  	pcie->ops->deinit(pcie);
> +err_disable_phy:
> +	phy_power_off(pcie->phy);
>  
>  	return ret;
>  }
> -- 
> 2.7.4

-- 
~Vinod