lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 24 Aug 2020 01:18:54 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Qian Cai <cai@....pw>
Cc:     kieran.bingham+renesas@...asonboard.com, airlied@...ux.ie,
        daniel@...ll.ch, dri-devel@...ts.freedesktop.org,
        linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM

Hi Qian,

On Fri, Aug 21, 2020 at 09:20:37PM -0400, Qian Cai wrote:
> On Mon, Jun 08, 2020 at 06:16:22AM +0300, Laurent Pinchart wrote:
> > Hi Qian,
> > 
> > I forgot to mention, I think the subject line should be
> > 
> > drm/rcar-du: Make DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU
> > 
> > Could you please let me know if you're OK with these two small changes ?
> 
> Laurent, this patch is still not in the latest linux-next. Can you take a look?

Sorry for the delay. It will be included in the pull request I send this
week.

> > On Mon, Jun 08, 2020 at 06:14:43AM +0300, Laurent Pinchart wrote:
> > > On Sun, Jun 07, 2020 at 10:53:40PM -0400, Qian Cai wrote:
> > > > There is no need to select DRM_RCAR_WRITEBACK if DRM=n which just make
> > > 
> > > s/DRM=n/DRM_RCAR_DU=n/ here.
> > > 
> > > > the generated .config a bit ugly.
> > > > 
> > > >  # ARM devices
> > > >  #
> > > >  # end of ARM devices
> > > > 
> > > >  CONFIG_DRM_RCAR_WRITEBACK=y
> > > > 
> > > >  #
> > > >  # Frame buffer Devices
> > > > 
> > > > Let DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU instead.
> > > > 
> > > > Signed-off-by: Qian Cai <cai@....pw>
> > > 
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> > > 
> > > No need to submit a v3 if you agree with the above change, I'll fix it
> > > in my tree.
> > > 
> > > > ---
> > > >  drivers/gpu/drm/rcar-du/Kconfig | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
> > > > index 0919f1f159a4..3304b41f5611 100644
> > > > --- a/drivers/gpu/drm/rcar-du/Kconfig
> > > > +++ b/drivers/gpu/drm/rcar-du/Kconfig
> > > > @@ -48,3 +48,4 @@ config DRM_RCAR_VSP
> > > >  config DRM_RCAR_WRITEBACK
> > > >  	bool
> > > >  	default y if ARM64
> > > > +	depends on DRM_RCAR_DU

-- 
Regards,

Laurent Pinchart

Powered by blists - more mailing lists