linux-kernel - Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5DSX1pf3xxo=CGvgPmHcjMJoWFx74grVJBckSmjtF-RGg@mail.gmail.com>
Date:   Mon, 24 Aug 2020 18:36:07 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Matthias Schiffer <matthias.schiffer@...tq-group.com>
Cc:     Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

Hi Matthias,

On Mon, Aug 24, 2020 at 6:10 AM Matthias Schiffer
<matthias.schiffer@...tq-group.com> wrote:

> diff --git a/arch/arm/boot/dts/imx6qdl-tqma6.dtsi b/arch/arm/boot/dts/imx6qdl-tqma6.dtsi
> index 9513020ddd1a..7aaae83c1fae 100644
> --- a/arch/arm/boot/dts/imx6qdl-tqma6.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-tqma6.dtsi
> @@ -20,7 +20,7 @@
>  &ecspi1 {
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_ecspi1>;
> -       fsl,spi-num-chipselects = <1>;
> +       num-cs = <1>;

You could simply remove fsl,spi-num-chipselects without passing num-cs.

The spi core is able to count the number of chipselects passed via
cs-gpios in the device tree.