lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Aug 2020 09:22:23 +0200 From: Matthias Schiffer <matthias.schiffer@...tq-group.com> To: Fabio Estevam <festevam@...il.com> Cc: Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, NXP Linux Team <linux-imx@....com>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes On Mon, 2020-08-24 at 18:36 -0300, Fabio Estevam wrote: > Hi Matthias, > > On Mon, Aug 24, 2020 at 6:10 AM Matthias Schiffer > <matthias.schiffer@...tq-group.com> wrote: > > > diff --git a/arch/arm/boot/dts/imx6qdl-tqma6.dtsi > > b/arch/arm/boot/dts/imx6qdl-tqma6.dtsi > > index 9513020ddd1a..7aaae83c1fae 100644 > > --- a/arch/arm/boot/dts/imx6qdl-tqma6.dtsi > > +++ b/arch/arm/boot/dts/imx6qdl-tqma6.dtsi > > @@ -20,7 +20,7 @@ > > &ecspi1 { > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_ecspi1>; > > - fsl,spi-num-chipselects = <1>; > > + num-cs = <1>; > > You could simply remove fsl,spi-num-chipselects without passing num- > cs. > > The spi core is able to count the number of chipselects passed via > cs-gpios in the device tree. Hmm, unless I'm overlooking something, this is not going to work: - spi_get_gpio_descs() sets num_chipselect to the maximum of the num_chipselect set in the driver and the number of cs-gpios - spi_imx_probe() sets num_chipselect to 3 if not specified in the device tree So I think we would end up with 3 instead of 1 chipselect. Kind regards, Matthias
Powered by blists - more mailing lists