linux-kernel - Re: [PATCH] irqchip/eznps: Fix build error for !ARC700 builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200825072152.725jmtlcqah5oos4@linutronix.de>
Date:   Tue, 25 Aug 2020 09:21:52 +0200
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     Vineet Gupta <Vineet.Gupta1@...opsys.com>
Cc:     linux-snps-arc@...ts.infradead.org, linux-kernel@...r.kernel.org,
        oferle@...lanox.com, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] irqchip/eznps: Fix build error for !ARC700 builds

On 2020-08-24 16:01:49 [-0700], Vineet Gupta wrote:

A little of patch description wouldn't hurt. Especially since it is not
a simple move but IENABLE comes out of nowhere.

> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> Link: http://lists.infradead.org/pipermail/linux-snps-arc/2020-August/004032.html

That link gets lost if someone decides to recreate the pipermail archive
and you have no hint what it was. Using

  Link: https://lkml.kernel.org/r/20200824095831.5lpkmkafelnvlpi2@linutronix.de

instead will instead give you the message-id in case lore dies or the
lkml.kernel.org redirect service goes into retirement.

> Signed-off-by: Vineet Gupta <vgupta@...opsys.com>
> ---
>  arch/arc/plat-eznps/include/plat/ctop.h | 1 -
>  include/soc/nps/common.h                | 6 ++++++
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arc/plat-eznps/include/plat/ctop.h b/arch/arc/plat-eznps/include/plat/ctop.h
> index a4a61531c7fb..77712c5ffe84 100644
> --- a/arch/arc/plat-eznps/include/plat/ctop.h
> +++ b/arch/arc/plat-eznps/include/plat/ctop.h
> @@ -33,7 +33,6 @@
>  #define CTOP_AUX_DPC				(CTOP_AUX_BASE + 0x02C)
>  #define CTOP_AUX_LPC				(CTOP_AUX_BASE + 0x030)
>  #define CTOP_AUX_EFLAGS				(CTOP_AUX_BASE + 0x080)
> -#define CTOP_AUX_IACK				(CTOP_AUX_BASE + 0x088)
>  #define CTOP_AUX_GPA1				(CTOP_AUX_BASE + 0x08C)
>  #define CTOP_AUX_UDMC				(CTOP_AUX_BASE + 0x300)
>  
> diff --git a/include/soc/nps/common.h b/include/soc/nps/common.h
> index 9b1d43d671a3..8c18dc6d3fde 100644
> --- a/include/soc/nps/common.h
> +++ b/include/soc/nps/common.h
> @@ -45,6 +45,12 @@
>  #define CTOP_INST_MOV2B_FLIP_R3_B1_B2_INST	0x5B60
>  #define CTOP_INST_MOV2B_FLIP_R3_B1_B2_LIMM	0x00010422
>  
> +#ifndef AUX_IENABLE
> +#define AUX_IENABLE				0x40c
> +#endif
> +
> +#define CTOP_AUX_IACK				(0xFFFFF800 + 0x088)
> +
>  #ifndef __ASSEMBLY__
>  
>  /* In order to increase compilation test coverage */

Sebastian