linux-kernel - Re: [PATCH] perf: correct SNOOPX field offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200825174043.GQ1509399@tassilo.jf.intel.com>
Date:   Tue, 25 Aug 2020 10:40:43 -0700
From:   Andi Kleen <ak@...ux.intel.com>
To:     Al Grant <al.grant@...s.arm.com>
Cc:     linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        acme@...hat.com
Subject: Re: [PATCH] perf: correct SNOOPX field offset

On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote:
> perf_event.h has macros that define the field offsets in the
> data_src bitmask in perf records. The SNOOPX and REMOTE offsets
> were both 37. These are distinct fields, and the bitfield layout
> in perf_mem_data_src confirms that SNOOPX should be at offset 38.

Looks good.

Reviewed-by: Andi Kleen <ak@...ux.intel.com>

Probably should have a Fixes: header

-Andi