linux-kernel - Re: [PATCH 4.19 22/71] scsi: target: tcmu: Fix crash in tcmu_flush_dcache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200825194621.GA27453@duo.ucw.cz>
Date:   Tue, 25 Aug 2020 21:46:21 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        JiangYu <lnsyyj@...mail.com>,
        Daniel Meyerholt <dxm523@...il.com>,
        Mike Christie <michael.christie@...cle.com>,
        Bodo Stroesser <bstroesser@...fujitsu.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.19 22/71] scsi: target: tcmu: Fix crash in
 tcmu_flush_dcache_range on ARM

Hi!

> From: Bodo Stroesser <bstroesser@...fujitsu.com>
> 
> [ Upstream commit 3145550a7f8b08356c8ff29feaa6c56aca12901d ]
> 
> This patch fixes the following crash (see
> https://bugzilla.kernel.org/show_bug.cgi?id=208045)
> 
>  Process iscsi_trx (pid: 7496, stack limit = 0x0000000010dd111a)
>  CPU: 0 PID: 7496 Comm: iscsi_trx Not tainted 4.19.118-0419118-generic
>         #202004230533
>  Hardware name: Greatwall QingTian DF720/F601, BIOS 601FBE20 Sep 26 2019
>  pstate: 80400005 (Nzcv daif +PAN -UAO)
...
> The solution is based on patch:
> 
>   "scsi: target: tcmu: Optimize use of flush_dcache_page"
> 
> which restricts the use of tcmu_flush_dcache_range() to addresses from
> vmalloc'ed areas only.

Yeah, but the patch mentioned is not queued for 4.19, so we should not
be simply applying this to 4.19. Does it need to be cherry-picked,
too?

commit 3c58f737231e2c8cbf543a09d84d8c8e80e05e43
Author: Bodo Stroesser <bstroesser@...fujitsu.com>

    scsi: target: tcmu: Optimize use of flush_dcache_page
    
    (scatter|gather)_data_area() need to flush dcache after writing data to or

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)