lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 25 Aug 2020 21:56:20 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Vasant Hegde <hegdevasant@...ux.vnet.ibm.com>,
        Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH 4.19 65/71] powerpc/pseries: Do not initiate shutdown
 when system is running on UPS

Hi!

> We have a user space tool (rtas_errd) on LPAR to monitor for
> EPOW_SHUTDOWN_ON_UPS. Once it gets an event it initiates shutdown
> after predefined time. It also starts monitoring for any new EPOW

Yeah, so there's userspace tool, and currently systems _with_ that
tool work poorly with UPS.

So you have fixed that, and now, systems _without_ that tool will work
poorly.

That's not a fix for serious bug, that's behaviour change. You are
fixing one set of systems and breaking another.

I don't believe it is suitable for stable.

								Pavel

> @@ -118,7 +118,6 @@ static void handle_system_shutdown(char
>  	case EPOW_SHUTDOWN_ON_UPS:
>  		pr_emerg("Loss of system power detected. System is running on"
>  			 " UPS/battery. Check RTAS error log for details\n");
> -		orderly_poweroff(true);
>  		break;
>  
>  	case EPOW_SHUTDOWN_LOSS_OF_CRITICAL_FUNCTIONS:
> 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)

Powered by blists - more mailing lists