lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Aug 2020 16:09:13 -0600 From: Rob Herring <robh@...nel.org> To: Cristian Ciocaltea <cristian.ciocaltea@...il.com> Cc: Thomas Gleixner <tglx@...utronix.de>, Jason Cooper <jason@...edaemon.net>, Marc Zyngier <maz@...nel.org>, Andreas Färber <afaerber@...e.de>, Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-actions@...ts.infradead.org Subject: Re: [PATCH v5 1/3] dt-bindings: interrupt-controller: Add Actions SIRQ controller binding On Wed, Aug 19, 2020 at 07:37:56PM +0300, Cristian Ciocaltea wrote: > Actions Semi Owl SoCs SIRQ interrupt controller is found in S500, S700 > and S900 SoCs and provides support for handling up to 3 external > interrupt lines. > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...il.com> > --- > Changes in v5: > - Updated controller description statements both in the commit message > and the binding doc > > .../actions,owl-sirq.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.yaml > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.yaml b/Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.yaml > new file mode 100644 > index 000000000000..cf9b7a514e4e > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interrupt-controller/actions,owl-sirq.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Actions Semi Owl SoCs SIRQ interrupt controller > + > +maintainers: > + - Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org> > + - Cristian Ciocaltea <cristian.ciocaltea@...il.com> > + > +description: | > + This interrupt controller is found in the Actions Semi Owl SoCs (S500, S700 > + and S900) and provides support for handling up to 3 external interrupt lines. > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - actions,s500-sirq > + - actions,s700-sirq > + - actions,s900-sirq > + - const: actions,owl-sirq > + - const: actions,owl-sirq This should be dropped. You should always have the SoC specific compatible. > + > + reg: > + maxItems: 1 > + > + interrupt-controller: true > + > + '#interrupt-cells': > + const: 2 > + description: > + The first cell is the input IRQ number, between 0 and 2, while the second > + cell is the trigger type as defined in interrupt.txt in this directory. > + > + 'actions,ext-interrupts': > + description: | > + Contains the GIC SPI IRQ numbers mapped to the external interrupt > + lines. They shall be specified sequentially from output 0 to 2. > + $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 3 > + maxItems: 3 Can't you use 'interrupts' here? > + > +required: > + - compatible > + - reg > + - interrupt-controller > + - '#interrupt-cells' > + - 'actions,ext-interrupts' > + > +additionalProperties: false > + > +examples: > + - | > + sirq: interrupt-controller@...b0200 { > + compatible = "actions,s500-sirq", "actions,owl-sirq"; > + reg = <0xb01b0200 0x4>; > + interrupt-controller; > + #interrupt-cells = <2>; > + actions,ext-interrupts = <13>, /* SIRQ0 */ > + <14>, /* SIRQ1 */ > + <15>; /* SIRQ2 */ > + }; > + > +... > -- > 2.28.0 >
Powered by blists - more mailing lists