lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Aug 2020 07:37:02 +0900 From: Benjamin Poirier <benjamin.poirier@...il.com> To: Coiby Xu <coiby.xu@...il.com> Cc: devel@...verdev.osuosl.org, Manish Chopra <manishc@...vell.com>, "supporter:QLOGIC QLGE 10Gb ETHERNET DRIVER" <GR-Linux-NIC-Dev@...vell.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Dan Carpenter <dan.carpenter@...cle.com>, "open list:QLOGIC QLGE 10Gb ETHERNET DRIVER" <netdev@...r.kernel.org>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] staging: qlge: fix build breakage with dumping enabled On 2020-08-25 19:16 +0800, Coiby Xu wrote: [...] > > > @@ -1630,7 +1630,7 @@ void ql_dump_wqicb(struct wqicb *wqicb) > > > (unsigned long long)le64_to_cpu(wqicb->cnsmr_idx_addr)); > > > } > > > > > > -void ql_dump_tx_ring(struct tx_ring *tx_ring) > > > +void ql_dump_tx_ring(struct ql_adapter *qdev, struct tx_ring *tx_ring) > > > { > > > > This can be fixed without adding another argument: > > struct ql_adapter *qdev; > > > > if (!tx_ring) > > return; > > > > qdev = tx_ring->qdev; > > > > ... similar comment for the other instances. > > Thank you for the simpler solution! > > For QL_OB_DUMP and QL_IB_DUMP, `struct ql_adapter *qdev` can't be > obtained via container_of. So qdev are still directly passed to these > functions. That's right; sorry I didn't check those functions earlier.
Powered by blists - more mailing lists