linux-kernel - Re: [PATCH v2] arm64: dts: qcom: sc7180-trogdor: add initial trogdor and lazor dt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=WVP8-vQc9T8WAa7ExC4o081oYWhEoPTfKUQNhFXHE8wg@mail.gmail.com>
Date:   Tue, 25 Aug 2020 15:44:27 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Rob Clark <robdclark@...il.com>
Cc:     linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Rob Clark <robdclark@...omium.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Atul Dhudase <adhudase@...eaurora.org>,
        Venkata Lakshmi Narayana Gubba <gubbaven@...eaurora.org>,
        Evan Green <evgreen@...omium.org>,
        Cheng-Yi Chiang <cychiang@...omium.org>,
        Ajit Pandey <ajitp@...eaurora.org>,
        Alexandru Stan <amstan@...omium.org>,
        Sujit Kautkar <sujitka@...omium.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: qcom: sc7180-trogdor: add initial trogdor
 and lazor dt

Hi,

On Tue, Aug 25, 2020 at 3:27 PM Rob Clark <robdclark@...il.com> wrote:
>
> +       max98357a: audio-codec-0 {
> +               compatible = "maxim,max98357a";
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&amp_en>;
> +               sdmode-gpios = <&tlmm 23 GPIO_ACTIVE_HIGH>;
> +               #sound-dai-cells = <0>;
> +       };

Even though Device Tree spec says "audio-codec", I agree that
"audio-codec-0" should be fine.  Since this is at the top level that
could be important to disambiguate if there was more than one audio
codec.


> +&wifi {
> +       status = "okay";
> +       vdd-0.8-cx-mx-supply = <&vdd_cx_wlan>;
> +       vdd-1.8-xo-supply = <&pp1800_l1c>;
> +       vdd-1.3-rfa-supply = <&pp1300_l2c>;

Sorry, I should have been clearer.  Here you should add:

vdd-3.3-ch0-supply = <&pp3300_l10c>;
vdd-3.3-ch1-supply = <&pp3300_l11c>;

...the hack that was downstream was to stick the "ch1" regulator in
the "ch0" slot since Bluetooth was already holding the "ch0" regulator
open and the "ch1" wasn't part of the bindings yet.

Once the supplies are added for WiFi feel free to add my Reviewed-by tag.

-Doug