linux-kernel - Re: [PATCH] interconnect: Show bandwidth for disabled paths as zero in debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE=gft4zqA8mwt5UYBrBYNUzF4cQdg7m=Zv48ffe1Pbm1HXv4Q@mail.gmail.com>
Date:   Mon, 24 Aug 2020 20:22:50 -0700
From:   Evan Green <evgreen@...omium.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Georgi Djakov <georgi.djakov@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>, linux-pm@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>
Subject: Re: [PATCH] interconnect: Show bandwidth for disabled paths as zero
 in debugfs

On Wed, Jul 29, 2020 at 10:50 AM Matthias Kaehlcke <mka@...omium.org> wrote:
>
> For disabled paths the 'interconnect_summary' in debugfs currently shows
> the orginally requested bandwidths. This is confusing, since the bandwidth
> requests aren't active. Instead show the bandwidths for disabled
> paths/requests as zero.
>
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>

Looks good to me. I briefly mulled over the idea of showing the
disabled flag as a separate column, but I can't really think of how
that would be useful.

Reviewed-by: Evan Green <evgreen@...omium.org>