linux-kernel - Re: [PATCH] interconnect: Show bandwidth for disabled paths as zero in debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ef2fa54c-7a20-8d3a-67d2-b26f70ac80c1@linaro.org>
Date:   Thu, 27 Aug 2020 16:32:14 +0300
From:   Georgi Djakov <georgi.djakov@...aro.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        Evan Green <evgreen@...omium.org>,
        Douglas Anderson <dianders@...omium.org>
Subject: Re: [PATCH] interconnect: Show bandwidth for disabled paths as zero
 in debugfs

Hi Matthias,

Thanks for the patch!

On 8/25/20 03:08, Matthias Kaehlcke wrote:
> On Wed, Jul 29, 2020 at 10:50:12AM -0700, Matthias Kaehlcke wrote:
>> For disabled paths the 'interconnect_summary' in debugfs currently shows
>> the orginally requested bandwidths. This is confusing, since the bandwidth
>> requests aren't active. Instead show the bandwidths for disabled
>> paths/requests as zero.
>>
>> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> 
> ping, any comments on this?
> 

Looks good to me! Just in case, I'll also add:
Fixes: 7d374b209083 ("interconnect: Add helpers for enabling/disabling a path")

Thanks,
Georgi